168 expected penalties are applied to grade after extra credit points are added #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve readability of the code with named constants
…e itself dynamically
|
@19mdavenport See my comment to Paul above. Maybe would you help me run the code in order to test it on submissions? |
pawlh
reviewed
Feb 22, 2024
Comment on lines
+119
to
+126
| private GradingSettings getGradingSettings() { | ||
| // FIXME! Import from some dynamic location | ||
| return new GradingSettings( | ||
| 5, | ||
| 10, | ||
| 10 | ||
| ); | ||
| } |
There was a problem hiding this comment.
I like the future prep here 💯
|
Sorry, I created some conflicts between this and |
|
That's fine, I'll tackle it. Thanks for letting me know. |
|
The underlying issue has already been resolved by #263. If we want to preserve any of the other ideas from this PR, they'll come from a new one. |
frozenfrank
deleted the
168-expected-penalties-are-applied-to-grade-after-extra-credit-points-are-added
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #168.
It also begins to put some of the key functionality in place for #156 via a
GradingSettingsrecord.While I have confirmed that this code compiles, I'm not sure how to run it on submissions to verify that the results are correct. Please do that, or help me figure out how to.