172 holidays and weekends dont extend late calculation #219
Conversation
…ays in multiple formats
|
Woops, sorry I did not intend to add |
@pawlh That's ok. Since I see you already have it on another branch as well, I'll remove it. I am going to add one more test before I unmark this as a "draft." I forgot to validate that the due dates actually extend properly when the holidays are configured! |
frozenfrank
force-pushed
the
172-holidays-and-weekends-dont-extend-late-calculation
branch
from
3fb2dc3 to
d23eaf4
Compare
- Create shared functions to reduce code duplication - Create multiple new test cases to document how the function should behave NOTE that associated visualizations of the test cases are included with the PR.
…ends-dont-extend-late-calculation
|
@pawlh This is now ready for review |
|
@leesjensen You may appreciate thoroughness of the testing of this method. Because of the test cases evaluated, I am now very confident that this works as it is supposed to work. Hopefully, this will be appreciated as a way of future proofing this code and making it more accessible to future TA's. |
…fore using them. This loud check will warn developers before they have an attempt to use the code improperly.
frozenfrank
force-pushed
the
172-holidays-and-weekends-dont-extend-late-calculation
branch
from
6efd2bc to
edb79e5
Compare
|
For good measure, a screenshot of all the tests passing: 
|
pawlh
deleted the
172-holidays-and-weekends-dont-extend-late-calculation
branch
This resolves #172 with a very robust capability of reading configuration strings. This does not set up the dynamic string configuration since it needs to be decided on a higher level. That issue is contemplated in #156.
This introduces the ability to respond to configuration values in two different formats:
Examples of both formats are tested in appropriate test files.
While this isn't primarily concerned with this, we do introduce hard-coded settings to carry us through the 2024 calendar year. Some dates may be incorrect; rather than adjusting them here, we should choose a method for storing them more dynamically which this PR supports.
Credit to @prattnj for building the original pattern from which we have added this robust functionality. Thanks to @19mdavenport for support in creating the appropriate test files and determine the correct behavior.