-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable canvas and compilation #369
Conversation
Note that the commit message "RUN_COMPILATION can be controlled via ApplicationProperties" in commit 50cb2c6 is mostly a theoretical question. Nobody has shown me nor demonstrated where the |
There is no .properties file associated with ApplicationProperties. It's tied to command line arguments |
That explains it. I guess I just need some training on how to use the commandline arguments to adjust the values. Is there something more you're looking for from this PR, or how can I help this one become approved as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add support for your new property to where it exists in main Server class, as well as providing it as an option in the docker compose file?
@19mdavenport I can look into the main |
https://github.com/softwareconstruction240/autograder/blob/main/compose.yml you'd just need to add it with the rest of the command line arguments (lines 23-32) |
50cb2c6
to
9cedd8c
Compare
…ose file... Add commandline flag --disable-run-compilaion The Grader class checks this value freshly each time it is constructed. Add stub to docker compose file for --disable-run-compilation Rename --disable-run-compilation ==> --disable-compilation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@19mdavenport I've added the support you asked for.
(I still don't understand everything in that file, but I was able to follow the pattern to add support for the property. Thanks for the tip!)
This PR continues efforts begun in #328 by adding guards to newly added method calls. It also leverages the newly added
ApplicationProperties
system to read in the values from a properties file.