300 fullstack refactor rubicitems to be dynamic #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frozenfrank These changes may be helpful with #239 |
frozenfrank
reviewed
Jun 4, 2024
| @@ -47,7 +48,7 @@ private <T> Set<T> allPreviousPhases(PhaseFunction<T> func) throws GradingExcept | |||
| Phase previous = gradingContext.phase(); | |||
| while ((previous = PhaseUtils.getPreviousPhase(previous)) != null) { | |||
| RubricConfig rubricConfig = DaoService.getRubricConfigDao().getRubricConfig(previous); | |||
| if(rubricConfig.passoffTests() != null) { | |||
| if(rubricConfig.items().get(Rubric.RubricType.PASSOFF_TESTS) != null) { | |||
There was a problem hiding this comment.
Note: RubricConfig is still a class. We could provide helpful methods to preserve the existing method calls, and avoid all these code updates.
There was a problem hiding this comment.
There are only two instances where we get this with a specific type in mind rather than a dynamic variable type. I would think that adding extra methods would add extra clutter for not that much added benefit. Do you disagree?
src/main/resources/frontend/src/views/StudentView/ResultsPreview.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be fairly self explanatory. Converted the three RubricItem's to an EnumMap, so we can add things to the enum and it becomes a new item