Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update phase 6 passoff requirements #468

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Update phase 6 passoff requirements #468

merged 2 commits into from
Nov 12, 2024

Conversation

19mdavenport
Copy link
Collaborator

resolves #467

awaiting professor feedback if they would like to change any other requirements (making unit tests required for phase 5, for example)

@19mdavenport 19mdavenport linked an issue Nov 7, 2024 that may be closed by this pull request
Backend: Phase 6 tests should be all required #467
Closed
frozenfrank
frozenfrank approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@frozenfrank frozenfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job :) This is the signature that the system was properly built the first time ✅

@frozenfrank
Copy link
Contributor

awaiting professor feedback if they would like to change any other requirements (making unit tests required for phase 5, for example)

@leesjensen @jerodw Do you have any feedback on this question?

@frozenfrank frozenfrank added the important This has been deemed important by the professors for immediate attention label Nov 7, 2024
@19mdavenport
Copy link
Collaborator Author

@frozenfrank I have been in email communication with them and will report when a consensus is reached.

@19mdavenport 19mdavenport merged commit f3b893b into main Nov 12, 2024
2 checks passed
@19mdavenport 19mdavenport deleted the 467-backend-phase-6-tests-should-be-all-required branch November 12, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozenfrank frozenfrank frozenfrank approved these changes

Assignees
No one assigned
Labels
important This has been deemed important by the professors for immediate attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backend: Phase 6 tests should be all required
2 participants
@19mdavenport @frozenfrank