Test server endpoints #483
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, JavaSpark intervenes and returns a 404 HTML page.
It was meant to be in a different branch.
…or every endpoint
webecke
reviewed
Nov 20, 2024
webecke
requested changes
Nov 20, 2024
There was a problem hiding this comment.
This is looking awesome! This will be a big help in making sure our code actually works. The way that MockEndpointProvider implements EndpointProvider is great, because that will force us anytime we go add a new endpoint to go add it in the testing set up. To that end, currently the MockEndpointProvider is missing the shutdown, so the tests don't compile. Otherwise, it LGTM!
First by authorization (none/student/admin), then alphabetically by path.
Our TestServerFacade thinks PATCH is invalid, and it's arguably kinda pointless anyway.
src/test/java/edu/byu/cs/server/exception/ResponseParseException.java
Outdated
Show resolved
Hide resolved
19mdavenport
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple framework for testing Server endpoints and implements some basic tests.
Significant changes
Mockito.mock()doesn't work on its own)Dependencies