Fix late penalty notes #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webecke
approved these changes
Nov 26, 2024
| notes += " Late penalty maxed out at " + numDaysLate + " days late: -"; | ||
| else if (numDaysLate > 0) | ||
| notes += " " + numDaysLate + " days late: -"; | ||
| notes += (int)(numDaysLate * PER_DAY_LATE_PENALTY * 100) + "% "; |
There was a problem hiding this comment.
what silly goose wrote this code?
| @@ -465,6 +461,25 @@ else if (numDaysLate > 0) | |||
| ); | |||
| } | |||
|
|
|||
| private String makeLatePenaltyNotes(int numDaysLate, int maxLateDays, String origNotes) { | |||
There was a problem hiding this comment.
I like that its a separate function now, makes it more clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the late penalty notes to not add anything if the submission is on time.