Update verifiable randomness functions.md #474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my second PR here update-compressed-nfts |
|
@mikemaccana any update on this ? |
mikemaccana
suggested changes
Oct 17, 2024
There was a problem hiding this comment.
Thanks for this @adpthegreat ! While you didn't win the prize for this lesson, we'd still love to get some of these fixes in - could you please rebase on top of current main?
adpthegreat
force-pushed
the
Update-verifiable-randomness-functions.md
branch
from
0ae4809 to
8bab4af
Compare
|
yeah I've done that now |
"build" is the command to build a project, but the correct tense in the context of that sentence would be "built"
* Updated * Updated * Updated * Updated
…oundation#543) * fix: required field * refactor: use a live account * fix: real data
…foundation#446) * Fixed grammar * Updated content as per comments * Formatted code
…dation#544) * Fix inconsistency in intro-to-custom-onchain-programs.md * Update intro-to-custom-onchain-programs.md * Update content/courses/intro-to-solana/intro-to-custom-onchain-programs.md --------- Co-authored-by: Mike MacCana <[email protected]>
…na-foundation#542) * Updated fromPubkey to use PublicKey in the transfer instruction * Update solana-pay.md * Fix duplicate fromPubkey in transfer instruction and correct indentation * fix indentation * fix indentation --------- Co-authored-by: Mike MacCana <[email protected]>
* fix typo ez fix * Update content/courses/program-optimization/program-architecture.md --------- Co-authored-by: Mike MacCana <[email protected]>
…undation#519) * update species to specifies * update species to specifies * Update content/courses/onchain-development/intro-to-anchor-frontend.md * Update content/courses/onchain-development/intro-to-anchor-frontend.md --------- Co-authored-by: Mike MacCana <[email protected]>
…h Expo (solana-foundation#461) * Update solana-mobile-dapps-with-expo.md * Run prettier the README file * Update the type Nft We don't use the @metaplex-foundation/js any more so we need to update the type NFT * Update solana-mobile-dapps-with-expo.md Fix README format * Migrate to Pinata Cloud instead of NFT Storage because they stopped their classic service since June 2024 * Update to Pinata Upload Image and Upload Data * Formatting + Remove unnecessary deps * Fix NftProvider + Update ContentBox * Update Code + Address all the issues * Small Fix + remove rn-fetch-blob because we don't need anymore. * Remove redundant console.log() * Small Fix Env variable * Update Docs + Small fix * Update content/courses/mobile/solana-mobile-dapps-with-expo.md * Update content/courses/mobile/solana-mobile-dapps-with-expo.md --------- Co-authored-by: Mike MacCana <[email protected]>
…n#512) * Updated content * Updated content * Updated content * Update content/courses/tokens-and-nfts/token-program-advanced.md * Update content/courses/tokens-and-nfts/token-program-advanced.md * Update content/courses/tokens-and-nfts/token-program-advanced.md * Update content/courses/tokens-and-nfts/token-program-advanced.md --------- Co-authored-by: Mike MacCana <[email protected]>
…foundation#452) * Updated contents and code snippets as per guidelines * Updated content * Resolved comments as per suggestions * Updated word highlight fix
* Update the Address Lookup Tables (LUTs) course to comply with the Solana contributing guide. - Simplified explanations of versioned transactions and Address Lookup Tables (LUTs). - Updated code examples to align with best practices. - Ensured the documentation followed the guidelines from the Solana contributing guide. - Enhance readability * Update lookup-tables.md - Update Course Codes * Update code snippets - Integrated the `@solana/web3.js `library's modern practices and utilized `@solana-developer/solana-helpers` where appropriate, including transaction confirmation and generating Solana Explorer links. - Enhanced explanation to increase readability * Update lookup-tables.md Fix some review * Update lookup-tables.md Updates Based on the Latest Review: - Revised certain sections for clarity - Added a callout - Fixed typos - Removed the usage of starter code and custom helpers in the lab section, and updated to create files from scratch - Import only the necessary function from `solana/web3.js` * Update lookup-tables.md - Add filenames
…na-foundation#510) * feat: update course to use umi and bubblegum plugin * Update content/courses/state-compression/compressed-nfts.md Co-authored-by: Mike MacCana <[email protected]> * feat: resolve requested changes * Update content/courses/state-compression/compressed-nfts.md --------- Co-authored-by: Mike MacCana <[email protected]>
* fix: missing redirects * chore: prettier
* code import refactor, sync and watch mode * husky precommit lint hook * mdx support * debug support * ignore node modules * optional quotes and line chaining * husky deprecation changes * use fs/promises * ignore contributing.md * package merge resolve * ignore pnpm lock * refactor: scripts --------- Co-authored-by: nickfrosty <[email protected]>
…ion#559) Co-authored-by: shivaji <[email protected]>
…on#555) * fix broken link * fix broken link 2 * Fix broken link 3 * change prerequisite to getting started * adjust workding * Fix broken link 4 * adjust wording * Fix prettier
…solana-foundation#504) the link no longer works; further research shows LTex is a sub-par alternative users don't enjoy, but I'm not sure if there are any other options for VSCode users. https://www.reddit.com/r/vscode/comments/1crtdg8/grammarly_extension_removed/
* fixing useMemo and balance in SOL * imported useMemo --------- Co-authored-by: shivaji <[email protected]>
…ana-foundation#567) * add back lang-rust, limitation, faq pages * prettier
…dks (solana-foundation#565) * Add solana4j open sourced by LMAX to the list of client-side java sdks * Fix linting problems
There has been a minor grammatical error in the doc. Add "than" at line 425 of the doc.
endencies
- Change escrow_state to escrow - Corrected solUsedSwitchBoardFeed to solUsdSwitchBoardFeed - Renamed escrow_amt to escrow_amount - Renamed VrfClientState to VrfClient - Replaced std::mem::size_of::<VrfClientState>() With VrfClient::INIT_SPACE + ANCHOR_DISCRIMINATOR, - Renamed all variables with ix to Instruction - Removed all unnecessary awaits - updated link to starter code from https://github.com/Unboxed/-Software/michael-burry-escrow To https://github.com/solana-developers/burry-escrow - edited headings from #### to ### for consistency
…n place of === - changed anchor.BN to BN - Wrapped solPrice with BN - Renamed tx to transaction in the burry-escrow.ts - Wrapped solPrice with BN - renamed e to error for more clarity - changed switchboard_solana back to switchboard_v2 since vrf is not yet supported in switchboard_solana
-Updated dependencies - prettier
- Updated dependencies - Renamed michael-burry-escrow to burry-escrow
adpthegreat
force-pushed
the
Update-verifiable-randomness-functions.md
branch
2 times, most recently
from
abe3be5 to
42555e8
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Updated link to starter code from https://github.com/Unboxed/-Software/michael-burry-escrow
To https://github.com/solana-developers/burry-escrow
Renamed escrowState to Escrow in the ts tests
Renamed VrfClientState to VrfClient
Corrected solUsedSwitchBoardFeed to solUsdSwitchBoardFeed
Renamed escrow_amt to escrow_amount
Renamed all variables with "ix" to Instruction
Renamed tx to transaction in the burry-escrow.ts
Used anchors INITSPACE ,instead of std::mem::size also replaced the magic number 8 with an anchor discriminator variable
Fixed some grammar errors
Removed unnecessary awaits in test
Changed the type for unlock_price from f64 to u64
edited subheadings from #### to ### for consistency
-Renamed VRF_STATE_SEED TO VRF_STATE
Updated assertions comparing numbers in tests to use .eq() method in place of ===
changed anchor.BN to BN
Wrapped solPrice with BN
renamed e to error for more clarity
Ran code to make sure tests work accordingly
Created PRs in https://github.com/solana-developers/burry-escrow to add branches vrf and vrf-challenge-solution as well as fixes to burry escrow