fix: check UTL verifiedness of tokens before showing spoof warning banner #288
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| return legacyCdnTokenInfo | ||
| ? { | ||
| ...legacyCdnTokenInfo, | ||
| verified: true, |
There was a problem hiding this comment.
@mcintyre94, I'm presuming that everything that comes from the legacy token list CDN can be presumed to be ‘verified.’ Does that make sense?
| tags | ||
| } | ||
| tags, | ||
| verified: !!(legacyCdnTokenInfo || sdkTokenInfo.verified), |
There was a problem hiding this comment.
This means ‘if you're on the legacy token list, or the UTL registry said you're verified, you're verified.’ Is that sound, @mcintyre94?
There was a problem hiding this comment.
Sorry, I missed this PR before! I think this is reasonable, but if the UTL registry contains the same token as unverified maybe that should take precedence?
So:
- Not on the legacy token list at all, UTL verified determines it
- On legacy token list and UTL, UTL verified determines it
- On legacy token list and not UTL, verified
There was a problem hiding this comment.
So, if I understand correctly, that basically implies that we should do this?
| verified: !!(legacyCdnTokenInfo || sdkTokenInfo.verified), | |
| verified: sdkTokenInfo.verified ?? false, |
- By this line, we know that
sdkTokenInfois non-null. - The ‘not on UTL but on legacy list’ case is handled above.
There was a problem hiding this comment.
Building a Vercel preview for that now: #289.
…nner # Summary The UTL provides a `verfied` property. Let's not show a token name/icon spoof warning banner unless that property is `false`. # Test Plan
steveluscher
added
the
automerge
This is a follow up on this comment: #288 (comment)
This is a follow up on this comment: #288 (comment) Reran the test plan from #288. Related to #229.
fix: check UTL verifiedness of tokens before showing spoof warning banner
Summary
The UTL provides a
verfiedproperty. Let's not show a token name/icon spoof warning banner unless that property isfalse.Test Plan
http://localhost:3000/address/2VhjJ9WxaGC3EZFwJG9BDUs9KxKCAjQY4vgd1qxgYWVg/transfers
http://localhost:3000/address/DezXAZ8z7PnrnRJjz3wXBoRgixCa6xjnB7YaB1pPB263
http://localhost:3000/address/FASTAr1in6u53vykPbCuFTUZnGdiLJrXaTEQ7UAArdBm
Fixes: #229.