Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count precompiled programs signatures to transaction cost #34524

Conversation

tao-stones
Copy link
Contributor

@tao-stones tao-stones commented Dec 19, 2023

Problem

Cost of signatures can be cleaner

Summary of Changes

  • refactor to simplify it by using SanitizedMessage

Fixes #

@tao-stones tao-stones marked this pull request as draft December 19, 2023 18:18
@tao-stones tao-stones requested a review from jstarry December 19, 2023 18:18
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f0133b) 81.8% compared to head (f58d69d) 81.8%.
Report is 429 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34524   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         820      820           
  Lines      221055   221053    -2     
=======================================
+ Hits       180887   180962   +75     
+ Misses      40168    40091   -77     

Copy link
Member

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a feature gate right? It will affect replay when we check the cost model there

@tao-stones tao-stones force-pushed the count-precompiled-program-signatures branch from f4ca555 to f58d69d Compare December 21, 2023 16:30
@tao-stones
Copy link
Contributor Author

This will need a feature gate right? It will affect replay when we check the cost model there

#29595 is currently blocked per feature schedule. But if it lands after that one, then yea, need feature gate for it.

@t-nelson
Copy link
Contributor

This will need a feature gate right? It will affect replay when we check the cost model there

#29595 is currently blocked per feature schedule. But if it lands after that one, then yea, need feature gate for it.

even if it doesn't, the min version for that feature needs bumped to whatever this lands in

@tao-stones
Copy link
Contributor Author

This will need a feature gate right? It will affect replay when we check the cost model there

#29595 is currently blocked per feature schedule. But if it lands after that one, then yea, need feature gate for it.

even if it doesn't, the min version for that feature needs bumped to whatever this lands in

good reminder!

I'll leave this PRT as Draft until measured execution costs for both programs, update block_cost_limits.rs before moving to Ready for Review.

@github-actions github-actions bot added stale [bot only] Added to stale content; results in auto-close after a week. and removed stale [bot only] Added to stale content; results in auto-close after a week. labels Jan 5, 2024
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Jan 22, 2024
@mergify mergify bot added community Community contribution need:merge-assist labels Jan 23, 2024
@github-actions github-actions bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Jan 23, 2024
@github-actions github-actions bot added stale [bot only] Added to stale content; results in auto-close after a week. and removed stale [bot only] Added to stale content; results in auto-close after a week. labels Feb 6, 2024
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Feb 21, 2024
@tao-stones
Copy link
Contributor Author

close it, will be addressed in other changes

@tao-stones tao-stones closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution need:merge-assist stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants