-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
count precompiled programs signatures to transaction cost #34524
count precompiled programs signatures to transaction cost #34524
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34524 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 820 820
Lines 221055 221053 -2
=======================================
+ Hits 180887 180962 +75
+ Misses 40168 40091 -77 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a feature gate right? It will affect replay when we check the cost model there
f4ca555
to
f58d69d
Compare
#29595 is currently blocked per feature schedule. But if it lands after that one, then yea, need feature gate for it. |
even if it doesn't, the min version for that feature needs bumped to whatever this lands in |
good reminder! I'll leave this PRT as Draft until measured execution costs for both programs, update |
close it, will be addressed in other changes |
Problem
Cost of signatures can be cleaner
Summary of Changes
Fixes #