rpc: Faster sorting for get_token_largest_accounts() #35263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #35263 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 833 833
Lines 224768 224825 +57
=========================================
+ Hits 183475 183511 +36
- Misses 41293 41314 +21 |
CriesofCarrots
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
What we should probably do is expand the api to be able to use a BinaryHeap during the accounts scan (like we do for native largest accounts link). But that is a more invasive change. This simple improvement lgtm in the meantime. 
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Please see #34584 for context.
The RPC method to get the largest token accounts, we sort everything even though we only return a max of 20.
Summary of Changes
Only sort the top 20 entries.
Note, this PR purposely does not tackle the issue of string parsing. That'll be handled in a subsequent PR.