Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split oper:spy in to oper:spy_user and oper:spy_channel #342

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jesopo
Copy link
Member

@jesopo jesopo commented Jun 10, 2022

No description provided.

@jesopo
Copy link
Member Author

jesopo commented Jun 10, 2022

unsure if operspy whois counts as spy_user or spy_channel - afaik it (currently) only exposes channel membership data which is spy_channel but it's against a user 🤷

@jesopo jesopo requested review from dwfreed and edk0 June 10, 2022 19:46
@jesopo jesopo marked this pull request as ready for review June 10, 2022 19:48
@jillest
Copy link
Contributor

jillest commented Jun 10, 2022

unsure if operspy whois counts as spy_user or spy_channel - afaik it (currently) only exposes channel membership data which is spy_channel but it's against a user shrug

Perhaps the right way is to align it with ConfigFileEntry.operspy_dont_care_user_info: things affected by that option are spy_user, all others are spy_channel.

modules/m_who.c Outdated Show resolved Hide resolved
@jesopo jesopo requested a review from dwfreed June 11, 2022 08:33
!user@host :gecos`` and ``/scan umodes +modes-modes global list`` to see
through secret channels, invisible users, etc.
``/chantrace !#channel``, ``/topic !#channel``, to see through secret channels,
see details of channels you are not int, etc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo; "not in".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
see details of channels you are not int, etc.
see details of channels you are not in, etc.

* channels etc. see /quote help operspy
* oper:spy_user: allows 'operspy' features to see user connection
* details. see /quote help operspy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is continued with tabs, the others are using spaces.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* details. see /quote help operspy
* details. see /quote help operspy

!user@host :gecos`` and ``/scan umodes +modes-modes global list`` to see
through secret channels, invisible users, etc.
``/chantrace !#channel``, ``/topic !#channel``, to see through secret channels,
see details of channels you are not int, etc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
see details of channels you are not int, etc.
see details of channels you are not in, etc.

* channels etc. see /quote help operspy
* oper:spy_user: allows 'operspy' features to see user connection
* details. see /quote help operspy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* details. see /quote help operspy
* details. see /quote help operspy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants