Remove WebSocket support #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronmdjones
force-pushed
the
amdj/remove-websockets
branch
from
c1c0edb
to
e86f66c
Compare
aaronmdjones
requested review from
dwfreed,
ilbelkyr,
rmcintosh,
tomaw,
spb and
df7cb
dwfreed
approved these changes
Mar 17, 2024
spb
approved these changes
Apr 14, 2024
tomaw
approved these changes
Jun 12, 2024
ilbelkyr
approved these changes
Jun 12, 2024
aaronmdjones
force-pushed
the
amdj/remove-websockets
branch
from
e86f66c
to
91408dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion on removing this has come up numerous times in the past, with the general consensus being that it is not wanted and does not work properly, but nothing has actually happened as far as trying to remove it before. Should we still decide we want to go ahead and remove it, this PR accomplishes that.