Fix issue with ranges and quotes in filterquery key parsing

solariumphp · Nov 9, 2016 · e93978f · e93978f
1 parent 13ee582
commit e93978f
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/library/Solarium/QueryBuilder/QueryBuilder.php b/library/Solarium/QueryBuilder/QueryBuilder.php
@@ -116,7 +116,9 @@ protected function parseFilterQueries(Query $query, Request $request)
             }
 
             if (!array_key_exists('key', $filterQueryParams)) {
-                preg_match_all('/\b([\w]+):/', $filterQueryParams['query'], $matches);
+                // Remove content inside quotes and brackets, as these can contain semicolons
+                $queryString = preg_replace('/[\"\[].*[\"\]]/u', '', $filterQueryParams['query']);
+                preg_match_all('/\b([\w]+):/', $queryString, $matches);
                 $key = implode('-', $matches[1]);
                 $filterQueryParams['key'] = $key;
 

diff --git a/tests/Solarium/QueryBuilder/Tests/QueryBuilderTest.php b/tests/Solarium/QueryBuilder/Tests/QueryBuilderTest.php
@@ -212,6 +212,36 @@ public function testQueryWithMultipleFilters()
         $this->assertEquals('cat:C', $filterQuery->getQuery());
     }
 
+    public function testQueryWithQuotedDateFilter()
+    {
+        $this->request->addParam('fq', 'startDate:"2016-01-01T00:00:00Z"');
+        $this->queryBuilder->build($this->query, $this->request);
+        $filterQueries = $this->query->getFilterQueries();
+
+        $this->assertCount(1, $filterQueries);
+        $filterQuery = current($filterQueries);
+        $this->assertEquals('startDate', $filterQuery->getKey());
+        $this->assertEquals('startDate:"2016-01-01T00:00:00Z"', $filterQuery->getQuery());
+    }
+
+    public function testQueryWithDateRangeFilters()
+    {
+        $this->request->addParam('fq', 'dateA:[2016-01-01T00:00:00Z TO 2016-01-02T00:00:00Z]');
+        $this->request->addParam('fq', 'dateB:["2016-01-01T00:00:00Z" TO "2016-01-02T00:00:00Z"]');
+        $this->queryBuilder->build($this->query, $this->request);
+        $filterQueries = $this->query->getFilterQueries();
+
+        $this->assertCount(2, $filterQueries);
+
+        $filterQuery = current($filterQueries);
+        $this->assertEquals('dateA', $filterQuery->getKey());
+        $this->assertEquals('dateA:[2016-01-01T00:00:00Z TO 2016-01-02T00:00:00Z]', $filterQuery->getQuery());
+
+        $filterQuery = next($filterQueries);
+        $this->assertEquals('dateB', $filterQuery->getKey());
+        $this->assertEquals('dateB:["2016-01-01T00:00:00Z" TO "2016-01-02T00:00:00Z"]', $filterQuery->getQuery());
+    }
+
     public function testQueryWithEmptyFilter()
     {
         $this->request->addParam('fq', '');