Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BC issue introduced in #1087 #1098

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

thomascorthals
Copy link
Member

Fixes #1097.

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0e1d769) 97.49% compared to head (eabb937) 97.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1098   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         389      389           
  Lines       10148    10148           
=======================================
  Hits         9894     9894           
  Misses        254      254           
Flag Coverage Δ
unittests 97.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Component/QueryTrait.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkalkbrenner mkalkbrenner merged commit 4d9a240 into solariumphp:master Oct 2, 2023
21 checks passed
@thomascorthals thomascorthals deleted the PHP8 branch October 2, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self return type is breaking change
2 participants