Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous composer require from example #1103

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

thomascorthals
Copy link
Member

Explicitly requiring psr/http-client isn't necessary for the example to work.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (724618a) 97.49% compared to head (d654a6f) 97.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1103   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         389      389           
  Lines       10148    10148           
=======================================
  Hits         9894     9894           
  Misses        254      254           
Flag Coverage Δ
unittests 97.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkalkbrenner mkalkbrenner merged commit cb4ea0a into solariumphp:master Nov 6, 2023
21 checks passed
@thomascorthals thomascorthals deleted the docs branch November 6, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants