Exclude member expressions from permissive tracking.

solidjs-community · Jan 1, 2024 · ce5606e · ce5606e
1 parent a1a7dd7
commit ce5606e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/docs/reactivity.md b/docs/reactivity.md
@@ -218,6 +218,10 @@ const Component = (props) => {
   return <div>{value()}</div>;
 };
 
+const Component = (props) => {
+  const [value] = createSignal(props.value);
+};
+
 const Component = (props) => {
   const derived = () => props.value;
   const oops = derived();

diff --git a/src/rules/reactivity.ts b/src/rules/reactivity.ts
@@ -836,6 +836,7 @@ export default createRule<Options, MessageIds>({
             if (
               isFunctionNode(traced) ||
               (traced.type === "Identifier" &&
+                traced.parent.type !== "MemberExpression" &&
                 !(traced.parent.type === "CallExpression" && traced.parent.callee === traced))
             ) {
               pushTrackedScope(childNode, "called-function");

diff --git a/test/rules/reactivity.test.ts b/test/rules/reactivity.test.ts
@@ -402,6 +402,13 @@ export const cases = run("reactivity", rule, {
         },
       ],
     },
+    {
+      code: `
+      const Component = props => {
+        const [value] = createSignal(props.value);
+      }`,
+      errors: [{ messageId: "untrackedReactive", type: T.MemberExpression }],
+    },
     // mark `props` as props by name before we've determined if Component is a component in :exit
     {
       code: `