Ensure args are encoded when fetching server function (#1409)

* Ensure args are encoded when fetching server function * Create friendly-experts-raise.md --------- Co-authored-by: Ryan Carniato <[email protected]>
solidjs · Mar 22, 2024 · c09d4bd · c09d4bd
1 parent 6dd28eb
commit c09d4bd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/friendly-experts-raise.md b/.changeset/friendly-experts-raise.md
@@ -0,0 +1,5 @@
+---
+"@solidjs/start": patch
+---
+
+Ensure args are encoded when fetching server function
diff --git a/packages/start/src/runtime/server-runtime.ts b/packages/start/src/runtime/server-runtime.ts
@@ -202,8 +202,8 @@ export function createServerReference(fn: Function, id: string, name: string) {
             const encodeArgs = options.method && options.method.toUpperCase() === "GET";
             return fetchServerFunction(
               encodeArgs
-                ? url + (args.length ? `&args=${JSON.stringify(await Promise.resolve(
-                  toJSONAsync(args, { plugins })))}` : "")
+                ? url + (args.length ? `&args=${encodeURIComponent(JSON.stringify(await Promise.resolve(
+                  toJSONAsync(args, { plugins }))))}` : "")
                 : `${baseURL}/_server`,
               `${id}#${name}`,
               options,