add typecheck back in

solidjs · Dec 8, 2023 · cb78e1c · cb78e1c
1 parent e5004cc
commit cb78e1c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/packages/start/package.json b/packages/start/package.json
@@ -6,6 +6,9 @@
   "publishConfig": {
     "access": "public"
   },
+  "scripts": {
+    "typecheck": "tsc --noEmit --checkJs false --skipLibCheck"
+  },
   "files": [
     "client",
     "config",

diff --git a/packages/start/server/handler.tsx b/packages/start/server/handler.tsx
@@ -1,9 +1,11 @@
 import { renderToStream } from "solid-js/web";
+/* @ts-ignore */
 import { provideRequestEvent } from "solid-js/web/storage";
 import {
   EventHandlerObject,
   EventHandlerRequest,
   H3Event,
+  HTTPMethod,
   eventHandler,
   sendRedirect,
   setHeader,
@@ -35,7 +37,7 @@ export function createHandler(
 
       return provideRequestEvent(event, async () => {
         // api
-        const match = matchAPIRoute(new URL(event.request.url).pathname, event.request.method)
+        const match = matchAPIRoute(new URL(event.request.url).pathname, event.request.method as HTTPMethod)
         if (match) {
           const mod = await match.handler.import();
           const fn = mod[event.request.method];

diff --git a/packages/start/shared/routes.ts b/packages/start/shared/routes.ts
@@ -1,4 +1,5 @@
-import fileRoutes, { RouteModule } from "vinxi/routes";
+import fileRoutes from "vinxi/routes";
+import { HTTPMethod } from "vinxi/server";
 
 interface Route {
   path: string;
@@ -27,10 +28,10 @@ declare module "vinxi/routes" {
   }
 }
 
-export const pageRoutes = defineRoutes(fileRoutes.filter(o => o.type === "page"));
-export const apiRoutes = defineAPIRoutes(fileRoutes.filter(o => o.type === "api"));
+export const pageRoutes = defineRoutes((fileRoutes as unknown as Route[]).filter(o => o.type === "page"));
+export const apiRoutes = defineAPIRoutes((fileRoutes as unknown as Route[]).filter(o => o.type === "api"));
 
-export function matchAPIRoute(path: string, method: Method) {
+export function matchAPIRoute(path: string, method: HTTPMethod) {
   const segments = path.split("/").filter(Boolean);
 
   routeLoop: for (const route of apiRoutes) {
@@ -72,7 +73,7 @@ export function matchAPIRoute(path: string, method: Method) {
   }
 }
 
-function defineRoutes(fileRoutes: RouteModule[]) {
+function defineRoutes(fileRoutes: Route[]) {
   function processRoute(routes: Route[], route: Route, id: string, full: string) {
     const parentRoute = Object.values(routes).find(o => {
       // if (o.id.endsWith("/index")) {