Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsconfig type to "vinxi/types/client" #1455

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

HansT01
Copy link
Contributor

@HansT01 HansT01 commented Apr 22, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

Typescript issue, so no tests have been made.

PR Type

What kind of change does this PR introduce?

  • Bugfix

AFAIK this should only affect new projects.

What is the current and new behavior?

See issue: #1454

Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: 571564c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@HansT01 HansT01 changed the title update type to "vinxi/types/client" Update tsconfig type to "vinxi/types/client" Apr 22, 2024
@HansT01 HansT01 marked this pull request as ready for review April 22, 2024 12:31
@HansT01
Copy link
Contributor Author

HansT01 commented Apr 22, 2024

Related commit: 090df26

@ryansolid
Copy link
Member

Oh is that where they ended up. Ok awesome.

@ryansolid ryansolid merged commit 79c17c9 into solidjs:main Apr 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants