Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serverComponents.server() to server-fns plugins when experimental.islands is enabled. #1560

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

jtag05
Copy link
Contributor

@jtag05 jtag05 commented Jun 25, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

Outlined in 1559
TL;DR production builds are not adding server action chunks when experimental.islands are enabled

What is the new behavior?

Chunks are generated as expected

Other information

Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: f340d48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jtag05
Copy link
Contributor Author

jtag05 commented Jun 25, 2024

I'm happy to add tests as soon as I can find where they are for the config file. I felt it was best to open this and start the discussion.

@ryansolid
Copy link
Member

Yeah its ok. This was an oversight in a sense. Like I'm not sure this will work perfectly but lets unblock and see what's broken.

@ryansolid ryansolid merged commit 9299944 into solidjs:main Jun 25, 2024
1 check passed
@jtag05 jtag05 deleted the issue-1559 branch June 26, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants