Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin vinxi packages in packages/start peerDependencies #1684

Closed

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Dec 6, 2024

Warning

This would technically make each bump of vinxi inside of start peerDeps require the vinxi outside of start to be bumped too.. and that means it's a breaking change every time.

It's very difficult to update vinxi and start right now, without causing some sort of version mismatch, because @solidjs/start and vinxi are updated separately, despite their versions in practice have to match.

Start depend directly on a number of @vinxi packages that aren't kept in sync with the vinxi package.

A simple solution is to pin vinxi inside of start peerDeps, with the other @vinxi packages

Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: 1d42e12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@birkskyum birkskyum closed this Dec 6, 2024
@birkskyum birkskyum changed the title Pin vinxi packages in packages/start dependencies Pin vinxi packages in packages/start peerDependencies Dec 6, 2024
@birkskyum birkskyum reopened this Dec 6, 2024
@birkskyum birkskyum marked this pull request as draft December 6, 2024 19:18
@birkskyum birkskyum closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant