Pin vinxi packages in packages/start peerDependencies #1684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This would technically make each bump of vinxi inside of start peerDeps require the vinxi outside of start to be bumped too.. and that means it's a breaking change every time.
It's very difficult to update vinxi and start right now, without causing some sort of version mismatch, because
@solidjs/start
andvinxi
are updated separately, despite their versions in practice have to match.Start depend directly on a number of
@vinxi
packages that aren't kept in sync with thevinxi
package.A simple solution is to pin vinxi inside of start peerDeps, with the other
@vinxi
packages