Skip to content

Commit

Permalink
Merge pull request #28 from boomer196/changes-for-solidus-v4.4.1
Browse files Browse the repository at this point in the history
  • Loading branch information
kennyadsl authored Dec 16, 2024
2 parents cacec02 + be3c34c commit 1c16be1
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 9 deletions.
8 changes: 4 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,28 @@ jobs:
run-specs-with-sqlite:
executor:
name: solidusio_extensions/sqlite
ruby_version: "3.0"
ruby_version: "3.2"
steps:
- browser-tools/install-chrome
- solidusio_extensions/run-tests
run-specs-with-postgres:
executor:
name: solidusio_extensions/postgres
ruby_version: "3.0"
ruby_version: "3.2"
steps:
- browser-tools/install-chrome
- solidusio_extensions/run-tests
run-specs-with-mysql:
executor:
name: solidusio_extensions/mysql
ruby_version: "3.0"
ruby_version: "3.2"
steps:
- browser-tools/install-chrome
- solidusio_extensions/run-tests
lint-code:
executor:
name: solidusio_extensions/sqlite-memory
ruby_version: "3.0"
ruby_version: "3.2"
steps:
- solidusio_extensions/lint-code

Expand Down
11 changes: 8 additions & 3 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,13 @@ branch = ENV.fetch('SOLIDUS_BRANCH', 'main')
gem 'solidus', github: 'solidusio/solidus', branch: branch

# The solidus_frontend gem has been pulled out since v3.2
gem 'solidus_frontend', github: 'solidusio/solidus_frontend' if branch == 'main'
gem 'solidus_frontend' if branch >= 'v3.2' # rubocop:disable Bundler/DuplicatedGem
if branch >= 'v3.2'
gem 'solidus_frontend'
elsif branch == 'main'
gem 'solidus_frontend', github: 'solidusio/solidus_frontend'
else
gem 'solidus_frontend', github: 'solidusio/solidus', branch: branch
end

# Needed to help Bundler figure out how to resolve dependencies,
# otherwise it takes forever to resolve them.
Expand All @@ -24,7 +29,7 @@ when 'mysql'
when 'postgresql'
gem 'pg'
else
gem 'sqlite3'
gem 'sqlite3', '~> 1.4'
end

gem 'rails-controller-testing'
Expand Down
2 changes: 1 addition & 1 deletion app/models/spree/stock/splitter/digital_splitter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def split_by_digital(package)

def hash_to_packages(digitals)
packages = []
digitals.each do |_id, contents|
digitals.each_value do |contents|
packages << build_package(contents)
end
packages
Expand Down
4 changes: 4 additions & 0 deletions lib/solidus_digital/engine.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ class Engine < Rails::Engine

engine_name 'solidus_digital'

initializer "solidus_digital.zeitwerk_ignore_deface_overrides", before: :eager_load! do |app|
app.autoloaders.main.ignore(root.join('app/overrides'))
end

initializer "spree.register.digital_shipping" do |app|
Rails.application.config.after_initialize do
::Spree::DigitalConfiguration = ::Spree::SpreeDigitalConfiguration.new
Expand Down
2 changes: 1 addition & 1 deletion solidus_digital.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ["lib"]

spec.add_dependency 'solidus', ['>= 2.0.0']
spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 5']
spec.add_dependency 'solidus_support', '~> 0.5'

spec.add_development_dependency 'rspec-activemodel-mocks'
Expand Down

0 comments on commit 1c16be1

Please sign in to comment.