Extension generator: Do not always require solidus_auth_devise #224
+1
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
Additionally, the maintainer may also want to add one of the following:
Once the correct labels have been set, simply remove the |
mergify
bot
added
the
needs changelog label
tvdeyen
approved these changes
Dec 3, 2024
tvdeyen
added
enhancement
mamhoff
force-pushed
the
do-not-use-solidus-auth-devise
branch
from
4201e92 to
a44574c
Compare
For integration specs, we can simply stub `spree_current_user` and `spree_user_signed_in?`.
mamhoff
force-pushed
the
do-not-use-solidus-auth-devise
branch
from
a44574c to
08cfa6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For integration specs, we can simply stub
spree_current_userandspree_user_signed_in?. See solidusio-contrib/solidus_reviews#122 for an example.