Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dependency on canonical-rails with tag helper #386

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Replace dependency on canonical-rails with tag helper #386

wants to merge 3 commits into from

Commits on Nov 29, 2024

  1. Add additional canonical tag test coverage 

    In a subsequent commit, we want to replace the canonical tag helper. So
having a record of the current behaviour will help us safely
re-implement the functionality.

We changed the spec type to `:feature` because there seems to be a
database persistence issue when running `:system` tests headfully. (i.e.
`ActiveRecord::RecordNotFound` errors for everything!) Seems like a
configuration problem.

Co-authored-by: benjamin wil <[email protected]>
    @forkata @benjaminwil
    forkata and benjaminwil committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    3ada9e0 View commit details
    Browse the repository at this point in the history

  2. Implement a simple canonical tag helper 

    This replaces the `canonical_tag` helper from `canonical-rails`. This
adds simple canonical tag generation, without all the options the gem
provides, but in a helper that can be customized by application
developers.

This would allow us to remove the `canonical-rails` gem as a dependency
going forward.

Co-authored-by: Benjamin Willems <[email protected]>
    @forkata @benjaminwil
    forkata and benjaminwil committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    599bc16 View commit details
    Browse the repository at this point in the history

  3. Remove dependency on canonical-rails 

    Now that we have introduced the `simple_canonical_tag` helper in the
previous commit, this is no longer used and needed.

Co-authored-by: Andrew Stewart <[email protected]>
Co-authored-by: Benjamin Willems <[email protected]>
    @forkata @stewart @benjaminwil
    3 people committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    ea158d6 View commit details
    Browse the repository at this point in the history