Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Russian language support #221

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

hummer007
Copy link
Contributor

Russian language has been added to the language options in the internationalization files. New entries for Russian (ru) have been made in each of the existing language files and a new language file has been created specifically for Russian (ru_RU.js). The dropdown for language selection in the App has been updated to include this new option.

Russian language has been added to the language options in the internationalization files. New entries for Russian (ru) have been made in each of the existing language files and a new language file has been created specifically for Russian (ru_RU.js). The dropdown for language selection in the App has been updated to include this new option.
Copy link
Owner

@solosky solosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my comments.

web/src/i18n/ru_RU.js Show resolved Hide resolved
This commit updates the language label for Russian across all language files from English and localized variations to Russian ('Русский'). This change is done to ensure proper language representation in every locale.
This commit updates the language labels in the Russian locale file (ru_RU.js) from Russian to their native representation. The languages affected are Simplified Chinese, Traditional Chinese (Taiwan), English, and Spanish. This enhances readability and user experience for speakers of these languages.
@solosky solosky changed the base branch from develop to main March 26, 2024 12:07
@solosky solosky changed the base branch from main to develop March 26, 2024 12:08
@solosky solosky merged commit 5b85e4c into solosky:develop Mar 26, 2024
@solosky
Copy link
Owner

solosky commented Mar 26, 2024

Thanks!

@hummer007 hummer007 deleted the feature/web-russian-language branch March 27, 2024 08:23
@MayanKoyote
Copy link
Contributor

MayanKoyote commented Mar 27, 2024

Just add a bit of meaning to these lines, otherwise it looks like classic machine translation nonsense.
At least something like this:

  1. changeok: 'Успешно сменить язык',

    -> changeok: 'Переключение языка прошло успешно!',

  2. message: 'Версия встроенного ПО вашего устройства слишком низкая. Пожалуйста, обновите последнюю версию ПО перед использованием функции загрузки.'

    -> message: 'Версия встроенного ПО вашего устройства слишком старая. Пожалуйста, обновитесь до последней версии ПО перед использованием функции загрузки.'

@hummer007
Copy link
Contributor Author

Just add a bit of meaning to these lines, otherwise it looks like classic machine translation nonsense. At least something like this:

  1. changeok: 'Успешно сменить язык',

    -> changeok: 'Переключение языка прошло успешно!',

  2. message: 'Версия встроенного ПО вашего устройства слишком низкая. Пожалуйста, обновите последнюю версию ПО перед использованием функции загрузки.'

    -> message: 'Версия встроенного ПО вашего устройства слишком старая. Пожалуйста, обновитесь до последней версии ПО перед использованием функции загрузки.'

I'm going to modify and make a PR.

@hummer007
Copy link
Contributor Author

@MayanKoyote you can check this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants