Uses assemblies in docker images and enables arm64+amd64 platforms #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjohnson
force-pushed
the
use_assemblies
branch
from
912ffbd
to
d2169e9
Compare
eduard-tita
reviewed
Nov 22, 2024
| export PATH=${env.PATH}:${env.WORKSPACE}/go/bin:${env.WORKSPACE}/bin | ||
| export GOPATH=${env.WORKSPACE} | ||
| go install -tags pkcs11 github.com/theupdateframework/notary/cmd/notary@latest | ||
| notary --help |
There was a problem hiding this comment.
notary --help - Is this line needed here?
There was a problem hiding this comment.
Not strictly needed. I liked it because it helped me debug locally to know it was installed and setup correctly.
eduard-tita
reviewed
Nov 22, 2024
| export PATH=${env.PATH}:${env.WORKSPACE}/go/bin:${env.WORKSPACE}/bin | ||
| export GOPATH=${env.WORKSPACE} | ||
| go install -tags pkcs11 github.com/theupdateframework/notary/cmd/notary@latest | ||
| notary --help |
There was a problem hiding this comment.
Same as above - is this line needed here?
eduard-tita
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included in this PR:
Overall docker image size is reduced by about 300MB.