Add support for annotation of DB Migration job #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wstewartlyra
changed the title
mealingr
reviewed
Sep 27, 2024
Comment on lines
+99
to
+100
| # Annotations to apply to the DB migration job | ||
| migrationJobAnnotations: |
There was a problem hiding this comment.
Could you please add a small test for this in iq-server-jobs_test.yaml to check setting this value applies the annotations correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When using a GitOps tool like ArgoCD to manage the deployment of the nexus-iq-server-ha helm chart, the db-migration job will run in an infinite loop when automatic sync functionality is enabled. Most GitOps tools like ArgoCD allow for Sync Hooks to be applied via annotations on resources, which can control the lifecycle of resources.
Because the job template for the db-migration resource doesn't allow applying annotations, it's not possible to apply the necessary annotations to apply sync hooks.
Proposed changes