[dpapp] Initial dpapp implementation being a vpp plugin #609

jimmyzhai · 2024-07-23T18:52:34Z

Following dpapp HLD - #606, this is the 3th part implementation. It implements the basic logic of inline flow creation, deletion and ageout.

Build with command make dpapp
Run with command make run-dpapp

KrisNey-MSFT · 2024-07-30T21:27:08Z

hi @jimmyzhai - is this ready to merge? Thank you!

KrisNey-MSFT · 2024-08-06T02:16:50Z

hi @jimmyzhai it looks like we have conflicts that need to be resolved please and thank you.

r12f · 2024-08-22T02:56:34Z

dash-pipeline/vpp-plugin/vpp.sh

@@ -0,0 +1,17 @@
+#!/bin/bash


also rename this file.

r12f · 2024-09-02T20:30:26Z

dash-pipeline/dpapp/CMakeLists.txt

@@ -0,0 +1,11 @@
+cmake_minimum_required(VERSION 3.5)


do you mind to add a README here to help people getting started on it?

KrisNey-MSFT · 2024-09-23T20:11:26Z

checking in @jimmyzhai - is this a lower priority in general? TY!

KrisNey-MSFT · 2024-10-24T21:54:01Z

just checking in :)

jimmyzhai · 2024-10-30T06:30:26Z

just checking in :)

I'm actively updating this PR now after #608 is merged.

KrisNey-MSFT · 2024-10-30T16:30:56Z

[like] Kristina Moore reacted to your message:

…

________________________________ From: Junhua Zhai ***@***.***> Sent: Wednesday, October 30, 2024 6:30:48 AM To: sonic-net/DASH ***@***.***> Cc: Kristina Moore ***@***.***>; Comment ***@***.***> Subject: Re: [sonic-net/DASH] [dpapp] Initial dpapp implementation being a vpp plugin (PR #609) just checking in :) I'm actively updating this PR now after #608<#608> is merged. — Reply to this email directly, view it on GitHub<#609 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFJSI6B6RQX6YTUMZWPPS2LZ6B4JRAVCNFSM6AAAAABLLAFHBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBVHE3TOMJUGE>. You are receiving this because you commented.Message ID: ***@***.***>

KrisNey-MSFT · 2024-11-05T22:20:07Z

hi @jimmyzhai - do you need help from @chrispsommers on this one?

jimmyzhai · 2024-11-12T09:34:11Z

hi @jimmyzhai - do you need help from @chrispsommers on this one?

Hi @chrispsommers, I've always encountered workflow DASH-BMV2-CI failure with many tries. The error is:

**The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

Run PTF Tests The operation was canceled.**

The error may happen sometimes before step "Run PTF Tests". The run-saithrift-ptftests succeeds in my local host. Looks the job is canceled by github action runner (due to running out of resources??). The runner host has 4 vCPUs, 16G memory (seen in step "Check dpapp status"). With adding dpapp, it takes more system overload and reaches limit? Any idea? Would you try to adjust github action runner host to more capacity machine (8 vCPUs) and re-run this workflow?

Found the cause. The runner is stopped due to sysctl vm.max_map_count = 1548, which limits max memory mapping number of one process.

dash-pipeline/dpapp/dash/dash.c

dash-pipeline/dpapp/dash/node.c

test/test-cases/functional/ptf/p4_dash_utils.py

dash-pipeline/dpapp/dash/dash.c

1. not enable dpdk_plugin.so, then not need hugepage allocation 2. Update NODE_FN dash_node to be simple

r12f

thanks Junhua for fixing the all the offline comments! I think there are a few more left that we have talked about but didn't change yet. I have left the comments there.

r12f · 2024-11-25T03:57:02Z

dash-pipeline/dpapp/dash/node.c

+    {
+        u32 n_left_to_next;
+
+        vlib_get_next_frame (vm, node, next_index, to_next, n_left_to_next);


thanks a lot for fixing this giant loop!

r12f · 2024-11-25T03:57:57Z

dash-pipeline/dpapp/dash/node.c

+    return DASH_ERROR_OK;
+}
+
+VLIB_NODE_FN (dash_node) (vlib_main_t * vm, vlib_node_runtime_t * node,


do you mind to rename this file to dash_node.c?

r12f · 2024-11-25T03:59:26Z

dash-pipeline/dpapp/dash/node.c

+VLIB_NODE_FN (dash_node) (vlib_main_t * vm, vlib_node_runtime_t * node,
+                          vlib_frame_t * frame)
+{
+    u32 n_left_from, *from, *to_next;


as we discussed last time, it will be better to give these variables more descriptive names: from/to/bi/b0 is way too vague for anyone to understand the code.

Most vpp plugins adhere to these names in node functions to express packet vector movement between current node and its next nodes. I prefer to be consistent with them. If we look at them and the uses in vlib_get_next_frame, vlib_put_next_frame, vlib_validate_buffer_enqueue_x1, etc as a whole, the naming is concise and clear.

r12f

thanks for fixing the variable namings! this change looks good to me now!

KrisNey-MSFT added the Ready to merge? label Jul 30, 2024

jimmyzhai force-pushed the dp_app_add_vpp_plugin branch from d8ad578 to 0c62cf8 Compare August 14, 2024 14:46

jimmyzhai requested a review from r12f August 14, 2024 16:00

r12f reviewed Aug 22, 2024

View reviewed changes

jimmyzhai force-pushed the dp_app_add_vpp_plugin branch 3 times, most recently from e2c1a02 to 1ac27da Compare September 2, 2024 12:48

r12f reviewed Sep 2, 2024

View reviewed changes

KrisNey-MSFT removed the Ready to merge? label Sep 4, 2024

jimmyzhai force-pushed the dp_app_add_vpp_plugin branch from 1ac27da to 527a726 Compare October 30, 2024 06:19

jimmyzhai force-pushed the dp_app_add_vpp_plugin branch 4 times, most recently from fb6bab2 to 765c873 Compare November 5, 2024 17:25

jimmyzhai force-pushed the dp_app_add_vpp_plugin branch 9 times, most recently from 276617b to 0b51e53 Compare November 6, 2024 07:45

jimmyzhai force-pushed the dp_app_add_vpp_plugin branch 2 times, most recently from 8f735d4 to 8031721 Compare November 12, 2024 09:25

jimmyzhai closed this Nov 12, 2024

jimmyzhai reopened this Nov 12, 2024

jimmyzhai force-pushed the dp_app_add_vpp_plugin branch 3 times, most recently from 21306ad to 27c84a6 Compare November 14, 2024 15:28

jimmyzhai requested a review from r12f November 14, 2024 15:57

jimmyzhai added 5 commits November 20, 2024 02:48

Add dpapp

2613930

Add ptf test saidashdpapp_sanity.py

dd15492

Build, run and test dpapp in workflow dash-bmv2-ci

cadf435

check p4 flow table for test case verification

15c37e6

Update dpapp/dpapp.sh

e0d5880

jimmyzhai force-pushed the dp_app_add_vpp_plugin branch from 27c84a6 to e0d5880 Compare November 20, 2024 09:54

Add dpapp README.md

073d10d

jimmyzhai force-pushed the dp_app_add_vpp_plugin branch from 7ddc499 to 073d10d Compare November 21, 2024 01:43

r12f approved these changes Nov 21, 2024

View reviewed changes

r12f reviewed Nov 21, 2024

View reviewed changes

r12f self-requested a review November 21, 2024 04:35

jimmyzhai force-pushed the dp_app_add_vpp_plugin branch from e5e9af3 to ea693a1 Compare November 22, 2024 04:31

jimmyzhai added 3 commits November 23, 2024 17:23

Fix per comments:

9fb1ce8

1. not enable dpdk_plugin.so, then not need hugepage allocation 2. Update NODE_FN dash_node to be simple

Raise assert error with message

542f59b

Support command arguments in send_p2a_pkt.py

b52014d

jimmyzhai force-pushed the dp_app_add_vpp_plugin branch from cae69c5 to b52014d Compare November 23, 2024 17:24

r12f reviewed Nov 25, 2024

View reviewed changes

r12f self-requested a review November 25, 2024 04:02

jimmyzhai added 2 commits November 25, 2024 09:49

rename node.c -> dash_node.c

0ba3493

Rename local variables to be descriptive in dash_node FN

c38e58b

r12f approved these changes Nov 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dpapp] Initial dpapp implementation being a vpp plugin #609

[dpapp] Initial dpapp implementation being a vpp plugin #609

jimmyzhai commented Jul 23, 2024 •

edited

Loading

KrisNey-MSFT commented Jul 30, 2024

KrisNey-MSFT commented Aug 6, 2024

r12f Aug 22, 2024

jimmyzhai Nov 15, 2024

r12f Sep 2, 2024

jimmyzhai Nov 20, 2024

KrisNey-MSFT commented Sep 23, 2024

KrisNey-MSFT commented Oct 24, 2024

jimmyzhai commented Oct 30, 2024

KrisNey-MSFT commented Oct 30, 2024 via email

KrisNey-MSFT commented Nov 5, 2024

jimmyzhai commented Nov 12, 2024

r12f left a comment

r12f Nov 25, 2024

r12f Nov 25, 2024

jimmyzhai Nov 25, 2024

r12f Nov 25, 2024

jimmyzhai Nov 25, 2024

r12f left a comment

[dpapp] Initial dpapp implementation being a vpp plugin #609

Are you sure you want to change the base?

[dpapp] Initial dpapp implementation being a vpp plugin #609

Conversation

jimmyzhai commented Jul 23, 2024 • edited Loading

KrisNey-MSFT commented Jul 30, 2024

KrisNey-MSFT commented Aug 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KrisNey-MSFT commented Sep 23, 2024

KrisNey-MSFT commented Oct 24, 2024

jimmyzhai commented Oct 30, 2024

KrisNey-MSFT commented Oct 30, 2024 via email

KrisNey-MSFT commented Nov 5, 2024

jimmyzhai commented Nov 12, 2024

r12f left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

r12f left a comment

Choose a reason for hiding this comment

jimmyzhai commented Jul 23, 2024 •

edited

Loading