Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gNOI Cold Reboot - Addition of new framework docker #20709

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rkavitha-hcl
Copy link

@rkavitha-hcl rkavitha-hcl commented Nov 6, 2024

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

This PR creates framework docker, which will be managing the Cold/Warm reboot requests from gNOI.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@rkavitha-hcl rkavitha-hcl requested a review from lguohan as a code owner November 6, 2024 07:27
@hdwhdw
Copy link

hdwhdw commented Nov 7, 2024

We should probably update the PR title and description. This is mainly adding a new container.

@vvolam
Copy link
Contributor

vvolam commented Nov 7, 2024

As discussed, please update README with docker dependencies and update sonic reboot/shutdown sequence accordingly to avoid crashes.

Also, please add exceptions around code that is dependent on other containers for better error handling.

@rkavitha-hcl rkavitha-hcl changed the title gNOI Cold Reboot gNOI Cold Reboot - Addition of new framework docker Nov 13, 2024
@rkavitha-hcl
Copy link
Author

We should probably update the PR title and description. This is mainly adding a new container.

Updated title and description.

@kishanps
Copy link

@hdwhdw Pls review

@kishanps
Copy link

@vvolam @qiluo-msft Pls review

@rkavitha-hcl
Copy link
Author

As discussed, please update README with docker dependencies and update sonic reboot/shutdown sequence accordingly to avoid crashes.

Also, please add exceptions around code that is dependent on other containers for better error handling.

Pl. refer to files/build_templates/framework.service.j2 in #20713 where the sequence is taken care

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants