Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gNOI Warm Reboot - rebootbackend changes #20786

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

rkavitha-hcl
Copy link

@rkavitha-hcl rkavitha-hcl commented Nov 13, 2024

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Enabled Rebootbackend to support gNOI Warm Reboot.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_wr_PR1 branch 2 times, most recently from ba55f24 to d734d22 Compare November 15, 2024 12:30
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_wr_PR1 branch 4 times, most recently from c07b6ce to 8a75037 Compare November 26, 2024 10:57
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_wr_PR1 branch 7 times, most recently from 50d08e6 to 383cb08 Compare December 4, 2024 06:58
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_wr_PR1 branch 2 times, most recently from 8fdbd07 to ec885af Compare December 5, 2024 10:07
@kishanps
Copy link

kishanps commented Dec 6, 2024

@github76543 Joh, can you PTAL and signoff.

@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_wr_PR1 branch 3 times, most recently from 566b7c8 to 292827c Compare December 12, 2024 07:00
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Pull request contains merge conflicts.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Pull request contains merge conflicts.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Pull request contains merge conflicts.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kishanps
Copy link

@hdwhdw Can you PTAL at the protected file error ?

@hdwhdw hdwhdw self-requested a review December 16, 2024 04:26
@hdwhdw
Copy link

hdwhdw commented Dec 16, 2024

@rkavitha-hcl The block on changing init_cfg is introduced in ed935d1, @wen587 can you instruct what's the right action here?

@hdwhdw hdwhdw requested a review from wen587 December 16, 2024 04:56
@wen587
Copy link
Contributor

wen587 commented Dec 16, 2024

@rkavitha-hcl The block on changing init_cfg is introduced in ed935d1, @wen587 can you instruct what's the right action here?

Hi @rkavitha-hcl , to unblock init_cfg.json.j2 change. It has to revert the PR: #19597. Then revert it back after your change.

@kishanps
Copy link

@rkavitha-hcl The block on changing init_cfg is introduced in ed935d1, @wen587 can you instruct what's the right action here?

Hi @rkavitha-hcl , to unblock init_cfg.json.j2 change. It has to revert the PR: #19597. Then revert it back after your change.

Thanks @hdwhdw & @wen587, adding @qiluo-msft in the loop as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants