Tunnel Term Table Attributes Tests #1255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the tests that require SRC_IP attributes for this change opencomputeproject/SAI#1799
|
|
|
@kcudnik these are the tests that I changed. |
|
we will need to wait with this until we pull new SAI headers |
|
hey, i'm updating syncd headers to the latest ones, and it requires to add some missing apis, and it wont pass tests because of SAI headers conditions in attributes, so i will let my self to cherrypick this change to my pr, and put everting in one go, so new headers will go, new code updated tests #1285 |
kcudnik
pushed a commit
to kcudnik/sonic-swss
that referenced
this pull request
Sep 5, 2023
From SAI v1.13.0 new attribute is required. See: sonic-net/sonic-sairedis#1255
kcudnik
pushed a commit
to kcudnik/sonic-swss
that referenced
this pull request
Sep 5, 2023
From SAI v1.13.0 new attribute is required. See: sonic-net/sonic-sairedis#1255
|
this is no longer needed when using relaxed flag, i will add extra test case for this scenario in #1285 |
|
Thank you for taking care of this @kcudnik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the tests that require SRC_IP attributes for this change opencomputeproject/SAI#1799