Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize counter polling interval by making it more accurate #1457

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+560 −43
Open

Optimize counter polling interval by making it more accurate #1457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a9acbdb
Support setting bulk size
stephenxs Sep 5, 2024
54cd45a
More accurate timestamps
stephenxs Sep 30, 2024
090a235
More debug information
stephenxs Oct 13, 2024
6d35990
Adjust code according to latest community
stephenxs Oct 29, 2024
6c1086a
Support bulk chunk size per counter ID
stephenxs Nov 19, 2024
2619c7e
Fix issue: the bulk context isn't removed when per counter ID chunk s…
stephenxs Dec 18, 2024
9624365
Unit test
stephenxs Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/RedisRemoteSaiInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,8 @@ sai_status_t RedisRemoteSaiInterface::notifyCounterGroupOperations(
std::string key((const char*)flexCounterGroupParam->counter_group_name.list, flexCounterGroupParam->counter_group_name.count);

emplaceStrings(POLL_INTERVAL_FIELD, flexCounterGroupParam->poll_interval, entries);
emplaceStrings(BULK_CHUNK_SIZE_FIELD, flexCounterGroupParam->bulk_chunk_size, entries);
emplaceStrings(BULK_CHUNK_SIZE_PER_PREFIX_FIELD, flexCounterGroupParam->bulk_chunk_size_per_prefix, entries);
emplaceStrings(STATS_MODE_FIELD, flexCounterGroupParam->stats_mode, entries);
emplaceStrings(flexCounterGroupParam->plugin_name, flexCounterGroupParam->plugins, entries);
emplaceStrings(FLEX_COUNTER_STATUS_FIELD, flexCounterGroupParam->operation, entries);
Expand Down
14 changes: 14 additions & 0 deletions lib/sairedis.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,20 @@ typedef struct _sai_redis_flex_counter_group_parameter_t
*/
sai_s8_list_t plugins;

/**
* @brief The bulk chunk size of the counter group
*
* It should be a number representing the bulk chunk size.
*/
sai_s8_list_t bulk_chunk_size;

/**
* @brief The bulk counter prefix map the counter group
*
* It should be a string representing bulk chunk size of each sub counter group.
*/
sai_s8_list_t bulk_chunk_size_per_prefix;

} sai_redis_flex_counter_group_parameter_t;

typedef struct _sai_redis_flex_counter_parameter_t
Expand Down
Loading
Loading