Fixed show interface counters on supervisor for packet chassis #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Dosi <[email protected]>
with large route scale of 70K+ routes this can log monit error Transiently which can also fail in sonic-mgmt. Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
|
/azp run |
|
Pull request contains merge conflicts. |
Signed-off-by: Abhishek Dosi <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Abhishek Dosi <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Abhishek Dosi <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@yejianquan for viz. |
yejianquan
reviewed
Jan 3, 2025
| @@ -405,7 +408,9 @@ def cnstat_print(self, cnstat_dict, ratestat_dict, intf_list, use_json, print_al | |||
| print(table_as_json(table, header)) | |||
| else: | |||
| print(tabulate(table, header, tablefmt='simple', stralign='right')) | |||
| if (multi_asic.is_multi_asic() or device_info.is_chassis()) and not use_json: | |||
| if device_info.is_voq_chassis(): | |||
There was a problem hiding this comment.
Does it mean for voq chassis, we don't have internal links, so run with '-d all' makes no differences?
There was a problem hiding this comment.
@yejianquan : yes for voq chassis we have fabric links [not ethernet links] and we have separate command to get counters for those.
BYGX-wcr
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
On Packet chassis for supervisor do the following:
show interfaces countergets sats from LCshow infeface counters -n <> -d allgets internal port statsshow infeface counters -d allgets internal port stats