Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/defi r (#1188) #1189

Open
wants to merge 53 commits into
base: master
Choose a base branch
from

Update AssetDetailsSBT.vue

ef09b04
Select commit
Loading
Failed to load commit list.
Open

Feature/defi r (#1188) #1189

Update AssetDetailsSBT.vue
ef09b04
Select commit
Loading
Failed to load commit list.
Soramitsu-Sonar-PR-decoration / sora2-wallet-web Sonarqube Results failed Oct 22, 2024 in 27s

Quality Gate failed

Failed

  • 46.20% Coverage on New Code (is less than 80.00%)
  • 6 New Issues (is greater than 0)

Analysis Details

6 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 6 Code Smells

Coverage and Duplications

  • Coverage 46.20% Coverage (39.40% Estimated after merge)
  • Duplications 0.82% Duplicated Code (0.90% Estimated after merge)

Project ID: sora2:sora2-wallet-web

View in SonarQube

Annotations

Check failure on line 66 in src/components/mixins/OperationsMixin.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-wallet-web Sonarqube Results

src/components/mixins/OperationsMixin.ts#L66

Refactor this function to reduce its Cognitive Complexity from 30 to the 15 allowed.

Check warning on line 42 in src/components/AssetListItem.vue

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-wallet-web Sonarqube Results

src/components/AssetListItem.vue#L42

Remove this unused import of 'state'.

Check notice on line 211 in src/components/AssetDetails/AssetDetailsTransferable.vue

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-wallet-web Sonarqube Results

src/components/AssetDetails/AssetDetailsTransferable.vue#L211

Complete the task associated to this "TODO" comment.

Check notice on line 356 in src/components/AssetDetails/AssetDetailsTransferable.vue

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-wallet-web Sonarqube Results

src/components/AssetDetails/AssetDetailsTransferable.vue#L356

Complete the task associated to this "TODO" comment.

Check warning on line 368 in src/components/AssetDetails/AssetDetailsTransferable.vue

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-wallet-web Sonarqube Results

src/components/AssetDetails/AssetDetailsTransferable.vue#L368

Replace this "switch" statement by "if" statements to increase readability.

Check warning on line 271 in src/store/account/actions.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-wallet-web Sonarqube Results

src/store/account/actions.ts#L271

Remove this useless assignment to variable "sbtAssetsList".