docs: update Tutorial 2 #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've updated to 0.17 so you'll need to resolve some merge conflicts. |
Adds an additional explanation that the `event_loop` needs to be updated after the window has been moved. While this is fixed in the input() section, including this mention in new() allows the program to compile during the new() and resize() section if the reader did not catch this themselves. Adds clarity following "changed State to own window" (09207e9) commit
With `wasm-bindgen-futures` being added as a dependency in tutorial 1 (bbe3d24), it is no longer necessary to add it again in tutorial 2. This section has been reworked as a note stating that WASM would fail to build without it.
|
I've rebased and fixed the conflict |
sotrh
requested changes
Oct 11, 2023
|
Updated |
sotrh
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of mild tweaks I felt would be beneficial after going through Tutorial 2: The Surface.