Use expiration timestamps for user privileges #26
Conversation
Fixes two issues: - Privileges don't decrement when a user is offline - No way of knowing if user had privileges in the past (needed for the 'supporter' attribute in the login message) The timestamp approach also reduces the number of writes to the database, since the timestamp is only updated when privileges are extended or reduced.
| @@ -197,28 +206,6 @@ class Sdb | |||
| upload_number = user[1].to!uint.ifThrown(0); | |||
| shared_files = user[2].to!uint.ifThrown(0); | |||
| shared_folders = user[3].to!uint.ifThrown(0); | |||
| something = 0; | |||
There was a problem hiding this comment.
I suspect that something might be like supporter or privileged (i.e. privileges > 0), but nobody has tested the user stats response given by the official server about what happens about privileged users.
There was a problem hiding this comment.
I've verified that it's not related to privileges, the value is always zero no matter which user. The attribute existed in the official server software in 2001, and its value was already zero at that point.
There was a problem hiding this comment.
Perhaps then it could be the "temp-ban" timer/flag, that would be set by the server for a short time to defend against a chat flooding or in case of a dictionary attack during login?
Of course if the user is temp-banned than they could not ever see this value being anything other than 0, nor could any other querying user see their stats while they are blocked, almost as if they didn't exist.
There was a problem hiding this comment.
I doubt it, but someone could verify.
Fixes two issues:
The timestamp approach also reduces the number of writes to the database, since the timestamp is only updated when privileges are extended or reduced.