feat(subscription-service): remove sonar issues

remove sonar issues BREAKING CHANGE: yes gh-34
sourcefuse · Sep 10, 2024 · 79a9735 · 79a9735
1 parent 4db5c4b
commit 79a9735
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/services/subscription-service/.gitignore b/services/subscription-service/.gitignore
@@ -49,7 +49,7 @@ typings/
 .node_repl_history
 
 # Output of 'npm pack'
-*.tgz
+# *.tgz
 
 # Yarn Integrity file
 .yarn-integrity

diff --git a/services/subscription-service/local-billing-0.0.1.tgz b/services/subscription-service/local-billing-0.0.1.tgz
diff --git a/services/subscription-service/src/controllers/billing-customer.controller.ts b/services/subscription-service/src/controllers/billing-customer.controller.ts
@@ -114,7 +114,7 @@ export class BillingCustomerController {
   ): Promise<{customerDetails: CustomerDto; info: BillingCustomer}> {
     const customers = await this.billingCustomerRepository.find(filter);
     if (customers.length == 0) {
-      throw new Error(' Customer with tenantId is not present');
+      throw new Error('Customer is not present');
     }
 
     const customer = await this.billingProvider.getCustomers(
@@ -173,7 +173,7 @@ export class BillingCustomerController {
     });
 
     if (customers.length == 0) {
-      throw new Error('Customer with tenantId is not present');
+      throw new Error(`Customer with tenantId ${tenantId} is not present`);
     }
     await this.billingProvider.updateCustomerById(
       customers[0].customerId,

diff --git a/services/subscription-service/src/controllers/webhook.controller.ts b/services/subscription-service/src/controllers/webhook.controller.ts
@@ -21,7 +21,6 @@ export class WebhookController {
   @intercept(WEBHOOK_VERIFIER)
   @post('/webhooks/billing-payment')
   async handleWebhook(@requestBody() payload: IPayload): Promise<void> {
-    const event = payload.event_type;
     const content = payload.content;
     await this.handlePayment(content);
   }