Send client-name, client-version query string parameters to completions #4018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
suggested changes
May 2, 2024
dominiccooney
force-pushed
the
dpc/client-name-version
branch
from
4f79ff1 to
e02ebc4
Compare
biome Update agent recordings Add client-name-version Revert spurious graph-context.test.ts change. Add missing symf recordings, update graph snapshot. De-flake an e2e test. Lowercase the client name, Sourcegraph server expects lowercase strings. Update agent recordings. Feedback
…t be reliably updated.
dominiccooney
force-pushed
the
dpc/client-name-version
branch
from
e02ebc4 to
ce5aec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CODY-1300
Sourcegraph 5.4 or later completions endpoint will start to check a minimum version asserted by the client. This starts sending the relevant header.
Part of sourcegraph/sourcegraph#62116
Test plan
CI
Note updated recordings have client-name, client-version query string parameters.
Manual test
Sign in to sg02.sourcegraphcloud.com and do a chat. You should see an error message like "Request Failed: ClientCodyIgnoreCompatibilityError: Cody for vscode version "1.16.0" doesn't match version constraint ">= 1.20.0" Note, the "vscode" and "1.16.0" strings come from the client.
Generate an autocomplete with alt-\ and check the Cody by Sourcegraph output category contains a cody.completion/error log:
JetBrains: Run JetBrains plugin with this agent and do similar actions. Error messages indicate the right client name and version are sent: