Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Makefile and run benchmarks as part of PRs #130

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

miparnisari
Copy link
Contributor

@miparnisari miparnisari commented Jan 6, 2024

This PR:

  • Adds a Makefile with make test and make lint and make bench
  • Adds a new workflow for main that runs benchmarks and saves them
  • Adds a new workflow for PRs that runs benchmarks and compares against main. When a benchmark regression occurs, it should fail the workflow, like so:
image

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30a99cd) 99.31% compared to head (0315771) 99.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          12       12           
  Lines         441      441           
=======================================
  Hits          438      438           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camdencheek camdencheek self-assigned this Jan 6, 2024
@camdencheek
Copy link
Member

Cool stuff, thank you! Looks like the cpuinfo stuff is currently failing. Any ideas there?

@miparnisari
Copy link
Contributor Author

@camdencheek can you approve a re-run of the build?

@camdencheek camdencheek merged commit 1124809 into sourcegraph:main Jan 21, 2024
4 checks passed
@camdencheek
Copy link
Member

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants