Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump golangci-lint to v1.54 #1881

Merged

Conversation

shahzadlone
Copy link
Member

Relevant issue(s)

Resolves #1880

Description

This bump fixes the nolintlint warning.

@shahzadlone shahzadlone added ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality labels Sep 14, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.7 milestone Sep 14, 2023
@shahzadlone shahzadlone requested a review from a team September 14, 2023 15:11
@shahzadlone shahzadlone self-assigned this Sep 14, 2023
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c70676e) 70.25% compared to head (c8e8b9c) 70.25%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1881   +/-   ##
========================================
  Coverage    70.25%   70.25%           
========================================
  Files          232      232           
  Lines        24192    24192           
========================================
  Hits         16996    16996           
  Misses        6031     6031           
  Partials      1165     1165           
Flag Coverage Δ
all-tests 70.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
errors/defraError.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c70676e...c8e8b9c. Read the comment docs.

@shahzadlone shahzadlone merged commit 6789b44 into sourcenetwork:develop Sep 14, 2023
14 checks passed
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)
Resolves sourcenetwork#1880 

## Description
This bump fixes the nolintlint warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nolintlint linter error with latest fix with golangci lint
2 participants