fix: Infinite loop when updating one-one relation #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
If the relationship references the same (host) collection, the function would in some circumstances return the known field. In collection.save, when updating via a secondary one-one field this leads to an infinite loop.
AndrewSisley
force-pushed
the
1914-one-one-infinite-loop
branch
from
c4f84dc to
5eb4343
Compare
AndrewSisley
added a commit
to AndrewSisley/defradb
that referenced
this pull request
Sep 27, 2023
Codecov ReportAll modified lines are covered by tests ✅
@@ Coverage Diff @@
## develop #1915 +/- ##
===========================================
+ Coverage 70.80% 70.84% +0.04%
===========================================
Files 233 233
Lines 24322 24334 +12
===========================================
+ Hits 17220 17238 +18
+ Misses 5930 5926 -4
+ Partials 1172 1170 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shahzadlone
pushed a commit
that referenced
this pull request
Oct 2, 2023
## Relevant issue(s) Resolves #1914 ## Description Fixes an a bug where an infinite loop may be created when updating a self-referencing one-one relation from the secondary side.
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1914 ## Description Fixes an a bug where an infinite loop may be created when updating a self-referencing one-one relation from the secondary side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1914
Description
Fixes an a bug where an infinite loop may be created when updating a self-referencing one-one relation from the secondary side.
The first commit documents the bug, the second commit fixes it.