fix: Remove collection name from schema ID generation #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a schema ID, not a collection ID, inculding the collection name makes no sense and is likely a historical artifact.
AndrewSisley
added
bug
AndrewSisley
changed the title
fredcarle
approved these changes
Oct 2, 2023
Codecov ReportAll modified lines are covered by tests ✅
@@ Coverage Diff @@
## develop #1920 +/- ##
===========================================
- Coverage 70.80% 70.73% -0.07%
===========================================
Files 233 233
Lines 24334 24331 -3
===========================================
- Hits 17229 17210 -19
- Misses 5932 5943 +11
- Partials 1173 1178 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…1920) ## Relevant issue(s) Resolves sourcenetwork#1083 ## Description Removes collection name from schema ID generation. It is a schema ID, not a collection ID, including the collection name makes no sense and is likely a historical artefact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1083
Description
Removes collection name from schema ID generation.
It is a schema ID, not a collection ID, including the collection name makes no sense and is likely a historical artefact.