Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use events to test network logic #2700

Merged
merged 42 commits into from
Jun 20, 2024

add event bus interface

573090e
Select commit
Loading
Failed to load commit list.
Merged

refactor: Use events to test network logic #2700

add event bus interface
573090e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 12, 2024 in 1s

76.46% (-1.46%) compared to 4510706

View this Pull Request on Codecov

76.46% (-1.46%) compared to 4510706

Details

Codecov Report

Attention: Patch coverage is 84.76821% with 23 lines in your changes missing coverage. Please review.

Project coverage is 76.46%. Comparing base (4510706) to head (573090e).

Current head 573090e differs from pull request most recent head d6a1be1

Please upload reports for the commit d6a1be1 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2700      +/-   ##
===========================================
- Coverage    77.91%   76.46%   -1.46%     
===========================================
  Files          310      309       -1     
  Lines        23113    22941     -172     
===========================================
- Hits         18008    17540     -468     
- Misses        3721     4042     +321     
+ Partials      1384     1359      -25     
Files Coverage Δ
cli/start.go 46.09% <ø> (+1.26%) ⬆️
internal/db/collection.go 71.60% <100.00%> (-0.23%) ⬇️
internal/db/collection_delete.go 39.53% <100.00%> (-2.69%) ⬇️
internal/db/config.go 100.00% <ø> (ø)
net/client.go 100.00% <100.00%> (ø)
net/process.go 65.38% <100.00%> (+0.68%) ⬆️
http/client.go 53.72% <0.00%> (-2.07%) ⬇️
event/bus.go 66.67% <66.67%> (ø)
internal/db/db.go 60.71% <71.43%> (-2.76%) ⬇️
internal/db/merge.go 74.78% <71.43%> (+4.56%) ⬆️
... and 5 more

... and 44 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4510706...d6a1be1. Read the comment docs.