-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Extract definition stuff from collection.go #2706
refactor: Extract definition stuff from collection.go #2706
Conversation
Cut-paste, no code has changed
Cut-paste, no code has changed
Cut-paste, no code has changed
Cut-paste, no code has changed
Cut-paste, no code changes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2706 +/- ##
===========================================
- Coverage 77.95% 77.85% -0.10%
===========================================
Files 308 310 +2
Lines 23125 23125
===========================================
- Hits 18025 18002 -23
- Misses 3715 3731 +16
- Partials 1385 1392 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers thanks for the re-org! LGTM
Relevant issue(s)
Resolves #2407
Description
Extracts collection create and patch, schema patch, and validation from collection.go.
It was getting really messy in collection.go and this should hopefully be a little better. No code has changed, only moved.