Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i): Update pubsub rpc version #2715

Merged

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #2714

Description

This is a simple update of the pubsub-rpc version. A fix was done on our fork of this package that removes the annoying error log that we would get.

2024-06-12T20:51:37.954-0400	ERROR	psrpc	[email protected]/rpc.go:350	subcription message handler: decoding response id: invalid cid: cid too short

@fredcarle fredcarle added the dependencies Related to dependencies label Jun 13, 2024
@fredcarle fredcarle added this to the DefraDB v0.12 milestone Jun 13, 2024
@fredcarle fredcarle requested a review from a team June 13, 2024 00:53
@fredcarle fredcarle self-assigned this Jun 13, 2024
@fredcarle fredcarle force-pushed the fredcarle/chore/pubsub-rpc-update branch from 1bf7101 to a73b46f Compare June 13, 2024 00:55
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.89%. Comparing base (4510706) to head (a73b46f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2715      +/-   ##
===========================================
- Coverage    77.91%   77.89%   -0.02%     
===========================================
  Files          310      310              
  Lines        23113    23113              
===========================================
- Hits         18008    18003       -5     
- Misses        3721     3725       +4     
- Partials      1384     1385       +1     
Flag Coverage Δ
all-tests 77.89% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4510706...a73b46f. Read the comment docs.

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredcarle fredcarle merged commit 6e96888 into sourcenetwork:develop Jun 13, 2024
39 checks passed
@fredcarle fredcarle deleted the fredcarle/chore/pubsub-rpc-update branch June 13, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pubsub-rpc version
2 participants