Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve incorrect merge conflict #2723

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #2673

Description

This PR fixes the incorrect merge conflict in our memory store.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

make test

Specify the platform(s) on which this was tested:

  • MacOS

@fredcarle fredcarle added bug Something isn't working area/datastore Related to the datastore / storage engine system labels Jun 14, 2024
@fredcarle fredcarle added this to the DefraDB v0.12 milestone Jun 14, 2024
@fredcarle fredcarle requested a review from a team June 14, 2024 19:59
@fredcarle fredcarle self-assigned this Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.95%. Comparing base (2b70154) to head (f0ab512).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2723      +/-   ##
===========================================
- Coverage    78.06%   77.95%   -0.11%     
===========================================
  Files          310      310              
  Lines        23231    23236       +5     
===========================================
- Hits         18133    18112      -21     
- Misses        3717     3732      +15     
- Partials      1381     1392      +11     
Flag Coverage Δ
all-tests 77.95% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
datastore/memory/txn.go 98.77% <100.00%> (-1.23%) ⬇️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b70154...f0ab512. Read the comment docs.

Copy link
Contributor

@islamaliev islamaliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fredcarle and others added 2 commits June 17, 2024 11:15
@fredcarle fredcarle force-pushed the fredcarle/fix/memory-store-merge-conflict branch from 6022369 to f0ab512 Compare June 17, 2024 15:15
Copy link
Member

@nasdf nasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing.

@fredcarle fredcarle merged commit 6626441 into sourcenetwork:develop Jun 17, 2024
38 of 39 checks passed
@fredcarle fredcarle deleted the fredcarle/fix/memory-store-merge-conflict branch June 17, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/datastore Related to the datastore / storage engine system bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate behaviour of transaction conflicts
4 participants