Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Inline array filters #3028

Merged
merged 9 commits into from
Sep 20, 2024

Merge branch 'develop' into nasdf/feat/inline-array-filter

17b7482
Select commit
Loading
Failed to load commit list.
Merged

feat: Inline array filters #3028

Merge branch 'develop' into nasdf/feat/inline-array-filter
17b7482
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 19, 2024 in 0s

79.46% (+0.12%) compared to 5754d7d

View this Pull Request on Codecov

79.46% (+0.12%) compared to 5754d7d

Details

Codecov Report

Attention: Patch coverage is 94.40559% with 16 lines in your changes missing coverage. Please review.

Project coverage is 79.46%. Comparing base (5754d7d) to head (17b7482).

Files with missing lines Patch % Lines
internal/connor/all.go 75.00% 5 Missing and 2 partials ⚠️
internal/connor/any.go 75.00% 5 Missing and 2 partials ⚠️
internal/connor/none.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3028      +/-   ##
===========================================
+ Coverage    79.34%   79.46%   +0.12%     
===========================================
  Files          333      336       +3     
  Lines        25841    26076     +235     
===========================================
+ Hits         20502    20719     +217     
- Misses        3870     3882      +12     
- Partials      1469     1475       +6     
Files with missing lines Coverage Δ
internal/connor/and.go 54.55% <ø> (ø)
internal/connor/connor.go 100.00% <100.00%> (ø)
internal/connor/eq.go 94.87% <100.00%> (+2.71%) ⬆️
internal/planner/mapper/mapper.go 88.83% <100.00%> (ø)
internal/request/graphql/schema/generate.go 88.06% <100.00%> (+0.10%) ⬆️
internal/request/graphql/schema/manager.go 98.67% <100.00%> (+0.23%) ⬆️
internal/request/graphql/schema/types/base.go 100.00% <100.00%> (ø)
internal/connor/none.go 60.00% <60.00%> (ø)
internal/connor/all.go 75.00% <75.00%> (ø)
internal/connor/any.go 75.00% <75.00%> (ø)

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5754d7d...17b7482. Read the comment docs.