Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Log GQL endpoint correctly on node start #3037

Merged

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #3036

Description

Logs the GQL endpoint correctly on node start.

@AndrewSisley AndrewSisley added bug Something isn't working documentation Improvements or additions to documentation area/api Related to the external API component area/cli Related to the CLI binary labels Sep 19, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.14 milestone Sep 19, 2024
@AndrewSisley AndrewSisley requested a review from a team September 19, 2024 15:30
@AndrewSisley AndrewSisley self-assigned this Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.31%. Comparing base (09b49c6) to head (8d415c8).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
node/node.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3037      +/-   ##
===========================================
- Coverage    79.34%   79.31%   -0.03%     
===========================================
  Files          333      333              
  Lines        25837    25837              
===========================================
- Hits         20498    20491       -7     
- Misses        3870     3874       +4     
- Partials      1469     1472       +3     
Flag Coverage Δ
all-tests 79.31% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
node/node.go 50.00% <0.00%> (ø)

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09b49c6...8d415c8. Read the comment docs.

Copy link
Member

@nasdf nasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@AndrewSisley AndrewSisley merged commit 926c334 into sourcenetwork:develop Sep 19, 2024
43 of 44 checks passed
@AndrewSisley AndrewSisley deleted the 3036-start-gql-endpoint-log branch September 19, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to the external API component area/cli Related to the CLI binary bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start logs incorrect string as gql endpoint
2 participants