-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ability to unrelate private documents from actors #3099
feat: Ability to unrelate private documents from actors #3099
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3099 +/- ##
==========================================
Coverage ? 80.08%
==========================================
Files ? 353
Lines ? 28068
Branches ? 0
==========================================
Hits ? 22478
Misses ? 4006
Partials ? 1584
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, but there are a couple of important todos for you before I can approve. My brain is a little foggy atm too, so it might be wise to wait for someone else to review too.
9c519d0
to
7abffb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I would prefer you got a second reviewer to look over this one before merge :) (don't wait more than a couple of working days for that though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor things to consider before merging. The documentation and tests are awesome as always!
7abffb2
to
b34dce9
Compare
b34dce9
to
e3f2770
Compare
… for deleting relationship
e3f2770
to
9d7e222
Compare
Relevant issue(s)
Resolves #2906
Description
Follow-up to #2907, the ability to delete a relationship (in order to revoke access from an identity).
CLI Demo
The following revokes the target actors 'relational' access to the private doc (can't read anymore):
Result:
How has this been tested?
CI + Integration Tests + Unit Tests